Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.h

Issue 374623002: [screen-orientation] Update implementation to match recent spec changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/screen_orientation/ScreenOrientation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/screen_orientation/ScreenOrientation.h
diff --git a/Source/modules/screen_orientation/ScreenOrientation.h b/Source/modules/screen_orientation/ScreenOrientation.h
index 1091cdb224e11d9e0cc04593744091375c632c2e..059890ad6d48c4bd40eb3cd95f0a0a634a285888 100644
--- a/Source/modules/screen_orientation/ScreenOrientation.h
+++ b/Source/modules/screen_orientation/ScreenOrientation.h
@@ -5,42 +5,60 @@
#ifndef ScreenOrientation_h
#define ScreenOrientation_h
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/events/EventTarget.h"
#include "core/frame/DOMWindowProperty.h"
-#include "platform/Supplementable.h"
-#include "platform/Timer.h"
#include "platform/heap/Handle.h"
-#include "public/platform/WebScreenOrientationLockType.h"
#include "public/platform/WebScreenOrientationType.h"
#include "wtf/text/AtomicString.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
-class Document;
+class ExecutionContext;
+class LocalFrame;
class ScriptPromise;
class ScriptState;
-class Screen;
+class ScreenOrientationController;
-class ScreenOrientation FINAL : public NoBaseWillBeGarbageCollectedFinalized<ScreenOrientation>, public WillBeHeapSupplement<Screen>, DOMWindowProperty {
+class ScreenOrientation FINAL :
+ public RefCountedGarbageCollectedWillBeGarbageCollectedFinalized<ScreenOrientation>,
+ public EventTargetWithInlineData,
+ DOMWindowProperty {
+ DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(RefCountedGarbageCollectedWillBeGarbageCollectedFinalized<ScreenOrientation>);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientation);
public:
- static ScreenOrientation& from(Screen&);
+ static ScreenOrientation* create(LocalFrame*);
+
virtual ~ScreenOrientation();
- static const AtomicString& orientation(Screen&);
- static ScriptPromise lockOrientation(ScriptState*, Screen&, const AtomicString& orientation);
- static void unlockOrientation(Screen&);
+ // EventTarget implementation.
+ virtual const WTF::AtomicString& interfaceName() const OVERRIDE;
+ virtual ExecutionContext* executionContext() const OVERRIDE;
+
+ String type() const;
+ unsigned short angle() const;
+
+ void setType(blink::WebScreenOrientationType);
+ void setAngle(unsigned short);
+
+ ScriptPromise lock(ScriptState*, const AtomicString& orientation);
+ void unlock();
+
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(change);
// Helper being used by this class and LockOrientationCallback.
static const AtomicString& orientationTypeToString(blink::WebScreenOrientationType);
- virtual void trace(Visitor* visitor) OVERRIDE { WillBeHeapSupplement<Screen>::trace(visitor); }
+ virtual void trace(Visitor*) OVERRIDE;
private:
- explicit ScreenOrientation(Screen&);
+ explicit ScreenOrientation(LocalFrame*);
+
+ ScreenOrientationController* controller();
- static const char* supplementName();
- Document* document() const;
+ blink::WebScreenOrientationType m_type;
+ unsigned short m_angle;
};
} // namespace WebCore
« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/screen_orientation/ScreenOrientation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698