LayoutTests/screen_orientation/orientationchange-event-subframe.html - Issue 374623002: [screen-orientation] Update implementation to match recent spec changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/orientationchange-event-subframe.html

Issue 374623002: [screen-orientation] Update implementation to match recent spec changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/orientationchange-event.html ('k') | LayoutTests/screen_orientation/page-visibility.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/orientationchange-event-subframe.html

diff --git a/LayoutTests/screen_orientation/orientationchange-event-subframe.html b/LayoutTests/screen_orientation/orientationchange-event-subframe.html

index f64053f0c4c1ec2702d39b862c7f673abff03213..d26090b74ef6d2c47207bd6541aeeda721a6ad0a 100644

--- a/LayoutTests/screen_orientation/orientationchange-event-subframe.html

+++ b/LayoutTests/screen_orientation/orientationchange-event-subframe.html

@@ -8,7 +8,7 @@

</iframe>

- var test = async_test("Test subframes receive 'orientationchange' events");

+ var test = async_test("Test subframes receive orientation change events");

var orientations = [

'portrait-primary',

@@ -17,7 +17,7 @@

'landscape-secondary'

];

- var currentIndex = orientations.indexOf(window.screen.orientation);

+ var currentIndex = orientations.indexOf(window.screen.orientation.type);

var eventsReceived = 0;

function getNextIndex() {

@@ -30,7 +30,7 @@

}

window.onmessage = test.step_func(function (ev) {

- assert_equals(ev.data, orientations[currentIndex], "subframe receives 'orientationchange' event");

+ assert_equals(ev.data, orientations[currentIndex], "subframe receives orientation change event");

++eventsReceived;

if (eventsReceived < 4)

changeOrientation()

« no previous file with comments | « LayoutTests/screen_orientation/orientationchange-event.html ('k') | LayoutTests/screen_orientation/page-visibility.html » ('j') | no next file with comments »