[screen-orientation] Update implementation to match recent spec changes.

Source/modules/screen_orientation/ScreenOrientationController.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScreenOrientationController_h
 #define ScreenOrientationController_h
 
 #include "core/page/PageLifecycleObserver.h"
 #include "platform/Supplementable.h"
 #include "public/platform/WebLockOrientationCallback.h"
 #include "public/platform/WebScreenOrientationLockType.h"
 #include "public/platform/WebScreenOrientationType.h"
 
 namespace blink {
 class WebScreenOrientationClient;
 }
 
 namespace WebCore {
 
+class ExecutionContext;
 class FrameView;
+class ScreenOrientation;
 
 class ScreenOrientationController FINAL : public NoBaseWillBeGarbageCollectedFinalized<ScreenOrientationController>, public WillBeHeapSupplement<LocalFrame>, public PageLifecycleObserver {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientationController);
     WTF_MAKE_NONCOPYABLE(ScreenOrientationController);
 public:
     virtual ~ScreenOrientationController();
 
     virtual void persistentHostHasBeenDestroyed() OVERRIDE;
 
-    blink::WebScreenOrientationType orientation() const;
+    void setOrientation(ScreenOrientation*);
+    void notifyOrientationChanged();
+
+    void lock(blink::WebScreenOrientationLockType, blink::WebLockOrientationCallback*);
+    void unlock();
+
+    const LocalFrame& frame() const;
 
     static void provideTo(LocalFrame&, blink::WebScreenOrientationClient*);
-    static ScreenOrientationController& from(LocalFrame&);
+    static ScreenOrientationController* from(LocalFrame&);
     static const char* supplementName();
 
-    void lockOrientation(blink::WebScreenOrientationLockType, blink::WebLockOrientationCallback*);
-    void unlockOrientation();
+    virtual void trace(Visitor*);
 
 private:
     explicit ScreenOrientationController(LocalFrame&, blink::WebScreenOrientationClient*);
     static blink::WebScreenOrientationType computeOrientation(FrameView*);
 
     // Inherited from PageLifecycleObserver.
     virtual void pageVisibilityChanged() OVERRIDE;
 
-    blink::WebScreenOrientationType m_overrideOrientation;
+    void updateOrientation();
+
+    PersistentWillBeMember<ScreenOrientation> m_orientation;

[abarth-chromium, 2014/07/07 17:29:33]

This pointer is cleared in ~ScreenOrientation, which will never execute because
this point keeps m_orientation alive....

[mlamouri (slow - plz ping), 2014/07/08 14:07:59]

I should have looked into that a bit more before uploading. I wanted to have a
raw pointer but blink-gc (clang plugin) forbids me to. I understand the general
reasons but here I know what I'm doing.

I came with another design where ScreenScreenOrientation is responsible to link
the controller and the ScreenOrientation object. It creates the link and
destroys it. I guess that should work but in practice, I still don't get a
ScreenOrientation dtor being called. I'm going to update the CL and have another
look.

     blink::WebScreenOrientationClient* m_client;
     LocalFrame& m_frame;
 };
 
 } // namespace WebCore
 
 #endif // ScreenOrientationController_h