LayoutTests/screen_orientation/resources/sandboxed-iframe-locking.html - Issue 374623002: [screen-orientation] Update implementation to match recent spec changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/screen_orientation/resources/sandboxed-iframe-locking.html

Issue 374623002: [screen-orientation] Update implementation to match recent spec changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix move Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/screen_orientation/resources/iframe-listen-orientation-change.html ('k') | LayoutTests/screen_orientation/screenorientation-api.html » ('j') | Source/modules/screen_orientation/PartialScreenOrientation.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <script>	3 <script>

4 var msg = "";	4 var msg = "";

5 screen.lockOrientation("portrait-primary").then(function() {	5 screen.orientation.lock("portrait-primary").then(function() {

6 }, function(error) {	6 }, function(error) {

7 msg = error.name;	7 msg = error.name;

8 });	8 });

9	9

10 // FIXME: for the moment, tests gets notified when there is a failure but	10 // FIXME: for the moment, tests gets notified when there is a failure but

11 // not a success, this hack should allow us to still have the test running.	11 // not a success, this hack should allow us to still have the test running.

12 // That should be removed as soon as we get a resolved promise in tests.	12 // That should be removed as soon as we get a resolved promise in tests.

13 setTimeout(function() {	13 setTimeout(function() {

14 parent.window.postMessage(msg, "*");	14 parent.window.postMessage(msg, "*");

15 })	15 })

16 </script>	16 </script>

17 </html>	17 </html>

OLD	NEW