LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html - Issue 374623002: [screen-orientation] Update implementation to match recent spec changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html

Issue 374623002: [screen-orientation] Update implementation to match recent spec changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/screen_orientation/lockOrientation-bad-argument-expected.txt ('k') | LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <html>

3 <body>

4 <script src="../resources/js-test.js"></script>

5 <script>

6 description("Validates that lockOrientation() returns false on bad orientation v alue in array argument.");

7 window.jsTestIsAsync = true;

8

9 function onOrientationChangeEvent(ev) {

10 testFailed("Unexpected 'orientationchange' event");

11 }

12

13 function completeTest() {

14 shouldBeEqualToString("screen.orientation", "portrait-primary");

15 screen.unlockOrientation();

16 finishJSTest();

17 }

18

19 window.addEventListener("orientationchange", onOrientationChangeEvent);

20

21 function typeErrorEnum(argStr) {

22 return "TypeError: Failed to execute 'lockOrientation' on 'Screen': parameter 1 ('" + argStr + "') is not a valid enum value.";

23 }

24

25 shouldBeEqualToString("screen.orientation", "portrait-primary");

26 // Bad argument to lockOrientation(), we should not get locked.

27 shouldThrow("screen.lockOrientation(['portrait-primary', 'invalid-orientation']) ", "typeErrorEnum('portrait-primary,invalid-orientation')");

28 shouldThrow("screen.lockOrientation(['portrait-primary', null])", "typeErrorEnum ('portrait-primary,')");

29 shouldThrow("screen.lockOrientation(['portrait-primary', undefined])", "typeErro rEnum('portrait-primary,')");

30 shouldThrow("screen.lockOrientation(['portrait-primary', 123])", "typeErrorEnum( 'portrait-primary,123')");

31 shouldThrow("screen.lockOrientation(['portrait-primary', window])", "typeErrorEn um('portrait-primary,[object Window]')");

32

33 // Finish asynchronously to give events a chance to fire.

34 setTimeout(completeTest, 0);

35 </script>

36 </body>

37 </html>

38

OLD	NEW