tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h - Issue 374593002: Support ignorance of base class finalizers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use early returns instead of fallthrough Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt ('k') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h

index 8d8ac3503223fc80fa990d7bad8284188f9b6b15..b3908f2aea9592798827c6d4810c94dc6ce89b34 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h

@@ -41,7 +41,7 @@ struct VectorTraits<WebCore::C> {

namespace WebCore {

// Off-heap vectors always need to be finalized.

-class NeedsFinalizer : public A {

+class NeedsFinalizer : public A, public ScriptWrappable {

public:

void trace(Visitor*);

private:

@@ -58,7 +58,7 @@ private:

};

// On-heap vectors with no inlined objects never need to be finalized.

-class DoesNotNeedFinalizer : public A {

+class DoesNotNeedFinalizer : public A, public ScriptWrappable {

public:

void trace(Visitor*);

private:

@@ -67,7 +67,7 @@ private:

// On-heap vectors with inlined objects that don't need destruction

// don't need to be finalized.

-class AlsoDoesNotNeedFinalizer : public A {

+class AlsoDoesNotNeedFinalizer : public A, public ScriptWrappable {

public:

void trace(Visitor*);

private: