tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt - Issue 374593002: Support ignorance of base class finalizers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked, static check now expressed by RecordInfo::NeedsFinalization() Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h ('K') | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h ('k') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h » ('j') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt

index 9e37c461218723814e553aaead89ccc015334167..4e2d324f2956dc63522bb843e614dafc6ef5d124 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt

@@ -1,14 +1,14 @@

In file included from class_requires_finalization_field.cpp:5:

-./class_requires_finalization_field.h:44:1: warning: [blink-gc] Class 'NeedsFinalizer' requires finalization.

-class NeedsFinalizer : public A {

+./class_requires_finalization_field.h:53:1: warning: [blink-gc] Class 'NeedsFinalizer' requires finalization.

+class NeedsFinalizer : public A, public ScriptWrappable {

-./class_requires_finalization_field.h:48:5: note: [blink-gc] Field 'm_as' requiring finalization declared here:

+./class_requires_finalization_field.h:57:5: note: [blink-gc] Field 'm_as' requiring finalization declared here:

Vector<Member<A> > m_as;

-./class_requires_finalization_field.h:53:1: warning: [blink-gc] Class 'AlsoNeedsFinalizer' requires finalization.

+./class_requires_finalization_field.h:62:1: warning: [blink-gc] Class 'AlsoNeedsFinalizer' requires finalization.

class AlsoNeedsFinalizer : public A {

-./class_requires_finalization_field.h:57:5: note: [blink-gc] Field 'm_bs' requiring finalization declared here:

+./class_requires_finalization_field.h:66:5: note: [blink-gc] Field 'm_bs' requiring finalization declared here:

HeapVector<B, 10> m_bs;

2 warnings generated.