tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt - Issue 374593002: Support ignorance of base class finalizers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked, static check now expressed by RecordInfo::NeedsFinalization() Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h ('K') | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp ('k') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h » ('j') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt

index 935883d07f315db7221ac31ee05a4c6aa5405f71..81e1bd6751ec3110d1010af2768e03e4830c5420 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt

@@ -1,8 +1,14 @@

In file included from class_requires_finalization_base.cpp:5:

-./class_requires_finalization_base.h:23:1: warning: [blink-gc] Class 'NeedsFinalizer' requires finalization.

+./class_requires_finalization_base.h:32:1: warning: [blink-gc] Class 'NeedsFinalizer' requires finalization.

class NeedsFinalizer : public A, public B {

-./class_requires_finalization_base.h:23:34: note: [blink-gc] Base class 'B' requiring finalization declared here:

+./class_requires_finalization_base.h:32:34: note: [blink-gc] Base class 'B' requiring finalization declared here:

class NeedsFinalizer : public A, public B {

-1 warning generated.

+./class_requires_finalization_base.h:49:1: warning: [blink-gc] Class 'GCedClassWithAScriptWrappableAndAFinalizableBase' requires finalization.

+class GCedClassWithAScriptWrappableAndAFinalizableBase

+./class_requires_finalization_base.h:51:7: note: [blink-gc] Base class 'B' requiring finalization declared here:

+ , public B

+ ^

+2 warnings generated.