tools/clang/blink_gc_plugin/RecordInfo.h - Issue 374593002: Support ignorance of base class finalizers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.h

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked, static check now expressed by RecordInfo::NeedsFinalization() Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/RecordInfo.h

diff --git a/tools/clang/blink_gc_plugin/RecordInfo.h b/tools/clang/blink_gc_plugin/RecordInfo.h

index a2fa10e7a7afd0570cad8d2338ff3545b23246b7..7dd9a4eed52c5711460600718ef322e302c3d48e 100644

--- a/tools/clang/blink_gc_plugin/RecordInfo.h

+++ b/tools/clang/blink_gc_plugin/RecordInfo.h

@@ -121,6 +121,7 @@ class RecordInfo {

CachedBool is_stack_allocated_;

CachedBool is_non_newable_;

CachedBool is_only_placement_newable_;

+ CachedBool does_need_finalization_;

bool determined_trace_methods_;

clang::CXXMethodDecl* trace_method_;