Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h

Issue 374593002: Support ignorance of base class finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h
diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h
index 9504dcac2fe3fe5fc0e73ade5d21636e11c075dd..1661d1af7d9946a81e4a0f93a85e53a6446726b3 100644
--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h
+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.h
@@ -19,6 +19,11 @@ public:
~B() { /* user-declared, thus, non-trivial */ }
};
+class ScriptWrappable {
+public:
+ ~ScriptWrappable() { /* user-declared, thus, non-trivial */ }
+};
+
// Second base class needs finalization.
class NeedsFinalizer : public A, public B {
public:
@@ -31,6 +36,18 @@ public:
void trace(Visitor*);
};
+class ClassWithIgnoredBasesDoesNotNeedFinalizer
+ : public A, public ScriptWrappable {
+public:
+ void trace(Visitor*);
+};
+
+class ClassWithSomeButNotAllIgnoredBasesDoesNeedFinalizer
+ : public A, public B, public ScriptWrappable {
+public:
+ void trace(Visitor*);
+};
+
}
#endif

Powered by Google App Engine
This is Rietveld 408576698