Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: Source/modules/webdatabase/SQLTransactionClient.cpp

Issue 374583002: Replace CallClosureTask::create(bind()) with createCrossThreadTask() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "modules/webdatabase/SQLTransactionClient.h" 32 #include "modules/webdatabase/SQLTransactionClient.h"
33 33
34 #include "core/dom/CrossThreadTask.h"
34 #include "core/dom/ExecutionContext.h" 35 #include "core/dom/ExecutionContext.h"
35 #include "modules/webdatabase/DatabaseBackendBase.h" 36 #include "modules/webdatabase/DatabaseBackendBase.h"
36 #include "modules/webdatabase/DatabaseContext.h" 37 #include "modules/webdatabase/DatabaseContext.h"
37 #include "platform/weborigin/DatabaseIdentifier.h" 38 #include "platform/weborigin/DatabaseIdentifier.h"
38 #include "platform/weborigin/SecurityOrigin.h" 39 #include "platform/weborigin/SecurityOrigin.h"
39 #include "public/platform/Platform.h" 40 #include "public/platform/Platform.h"
40 #include "public/platform/WebDatabaseObserver.h" 41 #include "public/platform/WebDatabaseObserver.h"
41 #include "wtf/Functional.h" 42 #include "wtf/Functional.h"
42 43
43 namespace WebCore { 44 namespace WebCore {
44 45
45 static void databaseModified(DatabaseBackendBase* database) 46 static void databaseModified(DatabaseBackendBase* database)
46 { 47 {
47 if (blink::Platform::current()->databaseObserver()) { 48 if (blink::Platform::current()->databaseObserver()) {
48 blink::Platform::current()->databaseObserver()->databaseModified( 49 blink::Platform::current()->databaseObserver()->databaseModified(
49 createDatabaseIdentifierFromSecurityOrigin(database->securityOrigin( )), 50 createDatabaseIdentifierFromSecurityOrigin(database->securityOrigin( )),
50 database->stringIdentifier()); 51 database->stringIdentifier());
51 } 52 }
52 } 53 }
53 54
54 void SQLTransactionClient::didCommitWriteTransaction(DatabaseBackendBase* databa se) 55 void SQLTransactionClient::didCommitWriteTransaction(DatabaseBackendBase* databa se)
55 { 56 {
56 ExecutionContext* executionContext = database->databaseContext()->executionC ontext(); 57 ExecutionContext* executionContext = database->databaseContext()->executionC ontext();
57 if (!executionContext->isContextThread()) { 58 if (!executionContext->isContextThread()) {
58 executionContext->postTask(bind(&databaseModified, PassRefPtrWillBeRawPt r<DatabaseBackendBase>(database))); 59 executionContext->postTask(createCrossThreadTask(&databaseModified, Pass RefPtrWillBeRawPtr<DatabaseBackendBase>(database)));
59 return; 60 return;
60 } 61 }
61 62
62 databaseModified(database); 63 databaseModified(database);
63 } 64 }
64 65
65 bool SQLTransactionClient::didExceedQuota(DatabaseBackendBase* database) 66 bool SQLTransactionClient::didExceedQuota(DatabaseBackendBase* database)
66 { 67 {
67 // Chromium does not allow users to manually change the quota for an origin (for now, at least). 68 // Chromium does not allow users to manually change the quota for an origin (for now, at least).
68 // Don't do anything. 69 // Don't do anything.
69 ASSERT(database->databaseContext()->executionContext()->isContextThread()); 70 ASSERT(database->databaseContext()->executionContext()->isContextThread());
70 return false; 71 return false;
71 } 72 }
72 73
73 } 74 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698