Force enterprise enrollment flow upon detection of inconsistent state.

chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/sequenced_task_runner.h"
+#include "chrome/browser/chromeos/login/startup_utils.h"
 #include "chrome/browser/chromeos/policy/device_policy_decoder_chromeos.h"
 #include "chrome/browser/chromeos/policy/enterprise_install_attributes.h"
 #include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
 #include "chrome/browser/chromeos/settings/owner_key_util.h"
 #include "policy/proto/device_management_backend.pb.h"
 
 namespace em = enterprise_management;
 
 namespace policy {
 
 DeviceCloudPolicyStoreChromeOS::DeviceCloudPolicyStoreChromeOS(
     chromeos::DeviceSettingsService* device_settings_service,
     EnterpriseInstallAttributes* install_attributes,
     scoped_refptr<base::SequencedTaskRunner> background_task_runner)
     : device_settings_service_(device_settings_service),
       install_attributes_(install_attributes),
       background_task_runner_(background_task_runner),
-      uma_done_(false),
+      first_update_(true),
       weak_factory_(this) {
   device_settings_service_->AddObserver(this);
 }
 
 DeviceCloudPolicyStoreChromeOS::~DeviceCloudPolicyStoreChromeOS() {
   device_settings_service_->RemoveObserver(this);
 }
 
 void DeviceCloudPolicyStoreChromeOS::Store(
     const em::PolicyFetchResponse& policy) {
@@ skipping 95 matching lines @@
   if (!install_attributes_->IsEnterpriseDevice()) {
     status_ = STATUS_BAD_STATE;
     NotifyStoreError();
     return;
   }
 
   // Fill UMA histogram once per session.  Skip temp validation error because it
   // is not a definitive result (policy load will be retried).
   const chromeos::DeviceSettingsService::Status status =
       device_settings_service_->status();
-  if (!uma_done_ &&
+  if (first_update_ &&
       status != chromeos::DeviceSettingsService::STORE_TEMP_VALIDATION_ERROR) {
-    uma_done_ = true;
+    first_update_ = false;
     const bool has_dm_token =
         status == chromeos::DeviceSettingsService::STORE_SUCCESS &&
         device_settings_service_->policy_data() &&
         device_settings_service_->policy_data()->has_request_token();
+
+    // At the time LoginDisplayHostImpl decides whether enrollment flow is to be
+    // started, policy hasn't been read yet, so LoginDisplayHostImpl is not in a
+    // position to decide whether recovery is required.  To work around this,
+    // upon policy load on machines requiring recovery, a flag is stored in
+    // prefs which is accessed by LoginDisplayHostImpl early during (next) boot.
+    if (!has_dm_token) {
+      LOG(ERROR) << "Policy read on enrolled device yields no DM token! "
+                 << "Status: " << status << ".";
+      chromeos::StartupUtils::MarkEnrollmentRecoveryRequired();
+    }
     UMA_HISTOGRAM_BOOLEAN("Enterprise.EnrolledPolicyHasDMToken", has_dm_token);
-    LOG_IF(ERROR, !has_dm_token)
-        << "Policy read on enrolled device yields no DM token! "
-        << "Status: " << status << ".";
   }
 
   switch (device_settings_service_->status()) {
     case chromeos::DeviceSettingsService::STORE_SUCCESS: {
       status_ = STATUS_OK;
       policy_.reset(new em::PolicyData());
       if (device_settings_service_->policy_data())
         policy_->MergeFrom(*device_settings_service_->policy_data());
 
       PolicyMap new_policy_map;
@@ skipping 18 matching lines @@
     case chromeos::DeviceSettingsService::STORE_VALIDATION_ERROR:
     case chromeos::DeviceSettingsService::STORE_TEMP_VALIDATION_ERROR:
       status_ = STATUS_LOAD_ERROR;
       break;
   }
 
   NotifyStoreError();
 }
 
 }  // namespace policy