Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 374553002: VAVEA: Turn VAAPI encoder flag into a kill switch. (Closed)

Created:
6 years, 5 months ago by Pawel Osciak
Modified:
6 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, jln+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

VAVEA: Turn VAAPI encoder flag into a kill switch. Flip the flag to enable VAVEA by default. Also update the CastStreamingApiTest to not require VP8, as we may be using H264 as well, but just assert on non-empty string for the codec. Do the same for the audio codec while we are here. TEST=encoding scenarios BUG=378962, 398322 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288920

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Fix CastStreamingApiTest test #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/bad_logging.js View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/basics.js View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/destination_not_set.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/stats.js View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vaapi_video_encode_accelerator.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 53 (0 generated)
Pawel Osciak
ptal
6 years, 5 months ago (2014-07-07 06:23:16 UTC) #1
wuchengli
lgtm
6 years, 5 months ago (2014-07-07 07:34:34 UTC) #2
piman
https://codereview.chromium.org/374553002/diff/1/content/common/gpu/media/vaapi_video_encode_accelerator.cc File content/common/gpu/media/vaapi_video_encode_accelerator.cc (right): https://codereview.chromium.org/374553002/diff/1/content/common/gpu/media/vaapi_video_encode_accelerator.cc#newcode117 content/common/gpu/media/vaapi_video_encode_accelerator.cc:117: (cpu.vendor_name() == "GenuineIntel") && (cpu.model() == 55)); You said ...
6 years, 5 months ago (2014-07-07 17:57:47 UTC) #3
Pawel Osciak
https://codereview.chromium.org/374553002/diff/1/content/common/gpu/media/vaapi_video_encode_accelerator.cc File content/common/gpu/media/vaapi_video_encode_accelerator.cc (right): https://codereview.chromium.org/374553002/diff/1/content/common/gpu/media/vaapi_video_encode_accelerator.cc#newcode117 content/common/gpu/media/vaapi_video_encode_accelerator.cc:117: (cpu.vendor_name() == "GenuineIntel") && (cpu.model() == 55)); On 2014/07/07 ...
6 years, 5 months ago (2014-07-08 05:32:42 UTC) #4
piman
On Mon, Jul 7, 2014 at 10:32 PM, <posciak@chromium.org> wrote: > > https://codereview.chromium.org/374553002/diff/1/content/ > common/gpu/media/vaapi_video_encode_accelerator.cc ...
6 years, 5 months ago (2014-07-08 17:30:48 UTC) #5
Pawel Osciak
On 2014/07/08 17:30:48, piman (slow to review) wrote: > On Mon, Jul 7, 2014 at ...
6 years, 5 months ago (2014-07-09 00:45:04 UTC) #6
piman
On 2014/07/09 00:45:04, Pawel Osciak wrote: > On 2014/07/08 17:30:48, piman (slow to review) wrote: ...
6 years, 5 months ago (2014-07-09 01:29:55 UTC) #7
Pawel Osciak
Removed CPU check and rebased. PTAL.
6 years, 5 months ago (2014-07-24 08:01:17 UTC) #8
piman
LGTM, thanks!
6 years, 5 months ago (2014-07-24 18:16:01 UTC) #9
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-07-28 08:03:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/20001
6 years, 4 months ago (2014-07-28 08:03:43 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 11:15:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 11:23:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clang_dbg/builds/440)
6 years, 4 months ago (2014-07-28 11:23:59 UTC) #14
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-07-29 00:04:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/20001
6 years, 4 months ago (2014-07-29 00:06:23 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 01:17:36 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 02:30:37 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/693)
6 years, 4 months ago (2014-07-29 02:30:38 UTC) #19
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-07-29 02:32:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/20001
6 years, 4 months ago (2014-07-29 02:34:37 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 03:45:01 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 05:00:37 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/723)
6 years, 4 months ago (2014-07-29 05:00:38 UTC) #24
posciak1
miu@: chrome/test/data/extensions/api_test/cast_streaming/* please. Thanks!
6 years, 4 months ago (2014-07-30 00:29:29 UTC) #25
miu
chrome/test/data/extensions/api_test/cast_streaming/* lgtm
6 years, 4 months ago (2014-07-30 00:33:13 UTC) #26
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-07-30 00:35:15 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/40001
6 years, 4 months ago (2014-07-30 00:38:58 UTC) #28
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-07-30 01:28:06 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/60001
6 years, 4 months ago (2014-07-30 01:30:06 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-30 07:31:35 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 08:44:59 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/1314)
6 years, 4 months ago (2014-07-30 08:45:01 UTC) #33
posciak1
The CQ bit was checked by posciak@google.com
6 years, 4 months ago (2014-07-30 09:20:29 UTC) #34
posciak1
The CQ bit was unchecked by posciak@google.com
6 years, 4 months ago (2014-07-30 09:20:32 UTC) #35
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-07-30 09:20:51 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/60001
6 years, 4 months ago (2014-07-30 09:22:40 UTC) #37
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-30 10:37:12 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 11:51:59 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/1344)
6 years, 4 months ago (2014-07-30 11:52:02 UTC) #40
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-07-31 00:38:53 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/60001
6 years, 4 months ago (2014-07-31 00:39:39 UTC) #42
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-31 03:08:18 UTC) #43
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 04:20:16 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/1678)
6 years, 4 months ago (2014-07-31 04:20:17 UTC) #45
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-08-12 00:23:04 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/60001
6 years, 4 months ago (2014-08-12 00:29:37 UTC) #47
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 00:41:07 UTC) #48
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 00:51:33 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/3100) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/2028)
6 years, 4 months ago (2014-08-12 00:51:35 UTC) #50
Pawel Osciak
The CQ bit was checked by posciak@chromium.org
6 years, 4 months ago (2014-08-12 01:04:22 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/374553002/80001
6 years, 4 months ago (2014-08-12 01:17:54 UTC) #52
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 05:47:50 UTC) #53
Message was sent while issue was closed.
Change committed as 288920

Powered by Google App Engine
This is Rietveld 408576698