Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 374543002: [fsp] Simplify browser tests by extracting the common code. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Simplify browser tests by extracting the common code. This patch extracts the common code used by most of File System Provider API browser tests to a helper extension. Note, that this is the first cleanup step. The next one would be creating a utility function for creating fake metadata (since it takes too much of each test). TEST=browser_tests: *FileSystemProvider* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281547

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -409 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/big_file/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/big_file/test.js View 8 chunks +14 lines, -57 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/evil/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/evil/test.js View 11 chunks +17 lines, -60 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js View 9 chunks +9 lines, -58 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mime_type/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mime_type/test.js View 5 chunks +49 lines, -89 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mount/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_directory/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_directory/test.js View 7 chunks +9 lines, -55 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js View 9 chunks +15 lines, -60 lines 0 comments Download
A chrome/test/data/extensions/api_test/file_system_provider/test_util/manifest.json View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/file_system_provider/test_util/test_util.js View 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/unmount/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/unmount/test.js View 3 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
mtomasz
@hirono: I finally found a way to reuse code between browser tests. PTAL. Thanks.
6 years, 5 months ago (2014-07-07 04:38:17 UTC) #1
hirono
On 2014/07/07 04:38:17, mtomasz wrote: > @hirono: I finally found a way to reuse code ...
6 years, 5 months ago (2014-07-07 05:04:04 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-07 05:16:50 UTC) #3
mtomasz
On 2014/07/07 05:04:04, hirono wrote: > On 2014/07/07 04:38:17, mtomasz wrote: > > @hirono: I ...
6 years, 5 months ago (2014-07-07 05:16:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/374543002/1
6 years, 5 months ago (2014-07-07 05:17:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 08:37:12 UTC) #6
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-07 08:46:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/374543002/20001
6 years, 5 months ago (2014-07-07 08:47:01 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 10:24:41 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 11:29:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/44845)
6 years, 5 months ago (2014-07-07 11:29:57 UTC) #11
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-07 12:17:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/374543002/20001
6 years, 5 months ago (2014-07-07 12:17:52 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 13:30:33 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-07 13:36:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/44874)
6 years, 5 months ago (2014-07-07 13:36:50 UTC) #16
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-07 13:57:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/374543002/20001
6 years, 5 months ago (2014-07-07 13:58:22 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-07 15:00:24 UTC) #19
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 16:02:30 UTC) #20
Message was sent while issue was closed.
Change committed as 281547

Powered by Google App Engine
This is Rietveld 408576698