Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 374533002: Enable WidgetCaptureTest.CaptureDesktopNativeWidget on desktop Linux (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
Elliot Glaysher, erg
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable WidgetCaptureTest.CaptureDesktopNativeWidget on desktop Linux BUG=163931 TEST=None TBR=erg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282556

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M ui/views/widget/widget_interactive_uitest.cc View 3 chunks +6 lines, -14 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
pkotwicz
Elliot, PTAL https://codereview.chromium.org/374533002/diff/20001/ui/views/widget/widget_interactive_uitest.cc File ui/views/widget/widget_interactive_uitest.cc (right): https://codereview.chromium.org/374533002/diff/20001/ui/views/widget/widget_interactive_uitest.cc#newcode964 ui/views/widget/widget_interactive_uitest.cc:964: // capture. This behavior is not desired ...
6 years, 5 months ago (2014-07-10 19:22:28 UTC) #1
erg
lgtm
6 years, 5 months ago (2014-07-10 21:15:23 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-11 00:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/374533002/20001
6 years, 5 months ago (2014-07-11 00:37:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 03:25:05 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 05:13:38 UTC) #6
Message was sent while issue was closed.
Change committed as 282556

Powered by Google App Engine
This is Rietveld 408576698