Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 374443003: clang/win: Fix "taking the address of a temporary" error. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

clang/wip: Fix "taking the address of a temporary" error. Also suppress a -Wwritable-strings warning while here. BUG=82385 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M printing/emf_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 5 months ago (2014-07-04 21:45:23 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-04 21:45:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/374443003/1
6 years, 5 months ago (2014-07-04 21:46:57 UTC) #3
Nico
Committed patchset #1 manually as r281445 (presubmit successful).
6 years, 5 months ago (2014-07-04 22:08:08 UTC) #4
Lei Zhang
6 years, 5 months ago (2014-07-07 18:53:45 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698