Issue 374443002: Cleanup: Rename UnitTestTest.cpp to RTConfRegistryTest.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 374443002: Cleanup: Rename UnitTestTest.cpp to RTConfRegistryTest.cpp (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Cleanup: Rename UnitTestTest.cpp to RTConfRegistryTest.cpp BUG=None TEST=make tests R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/0a65e385603f9f35d7cc0447bfad419f647e7c1e

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -19 lines)			Patch
M	gyp/tests.gypi	View	5 chunks	+5 lines, -5 lines	0 comments	Download
A +	tests/RTConfRegistryTest.cpp	View	0 chunks	+-1 lines, --1 lines	1 comment	Download
D	tests/UnitTestTest.cpp	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/374443002/diff/1/tests/RTConfRegistryTest.cpp File tests/RTConfRegistryTest.cpp (right): https://codereview.chromium.org/374443002/diff/1/tests/RTConfRegistryTest.cpp#newcode13 tests/RTConfRegistryTest.cpp:13: SkRTConfRegistry::UnitTest(); Perhaps follow up by moving the SKRTConfRegistry::UnitTest ...

6 years, 5 months ago (2014-07-07 12:43:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/374443002/1

6 years, 5 months ago (2014-07-08 17:21:27 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-08 17:33:33 UTC) #5

Message was sent while issue was closed.

Change committed as 0a65e385603f9f35d7cc0447bfad419f647e7c1e

Expand Messages | Collapse Messages