Issue 374413005: Handle bad ICO data better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 374413005: Handle bad ICO data better. (Closed)

Created:
6 years, 5 months ago by scroggo

Modified:
6 years, 5 months ago

Reviewers:
hal.canary

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Handle bad ICO data better. Interpret size and offset as size_t, as they should be. When read as int, they could be negative values. If they are negative (rather than positive and very large), they will not allow us to fail the length test, resulting in trying to read uninitialized memory. BUG=b/16010240 Committed: https://skia.googlesource.com/skia/+/57ad493789cb1a97574390b5ccf4fb9183ed3814

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/images/SkImageDecoder_libico.cpp	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scroggo

This file could use some serious rewriting, but this fixes the crash for now...

6 years, 5 months ago (2014-07-09 21:40:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/374413005/1

6 years, 5 months ago (2014-07-09 21:44:00 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-09 22:04:32 UTC) #5

Message was sent while issue was closed.

Change committed as 57ad493789cb1a97574390b5ccf4fb9183ed3814

Expand Messages | Collapse Messages