dart/site/try/src/editor.dart - Issue 374363002: Fix problem that caused deletion of tokens with multiple diagnostics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/site/try/src/editor.dart

Issue 374363002: Fix problem that caused deletion of tokens with multiple diagnostics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/site/try/src/editor.dart

diff --git a/dart/site/try/src/editor.dart b/dart/site/try/src/editor.dart

index afe92ab8b111c8086cf527acc224eaef24be6b8e..e8523d504e9eae00b003293bffe7a110a6eeed0a 100644

--- a/dart/site/try/src/editor.dart

+++ b/dart/site/try/src/editor.dart

@@ -164,7 +164,7 @@ addDiagnostic(String kind, String message, int begin, int end) {

Element parent = node.parent;

if (parent.classes.contains("diagnostic") &&

!interaction.oldDiagnostics.contains(parent)) {

- Element other = parent.lastChild;

+ Element other = parent.firstChild;

other.remove();

SpanElement wrapper = new SpanElement();

wrapper.style

« no previous file with comments | « no previous file | no next file » | no next file with comments »