Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 374353002: Fix up the annotated steps for the full dart2js builders (Closed)

Created:
6 years, 5 months ago by ricow1
Modified:
6 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix up the annotated steps for the full dart2js builders The regexp was updated, fix the indexes used to pull the shards, checked and minified flags R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=38078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/bots/compiler.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 5 months ago (2014-07-09 08:47:22 UTC) #1
karlklose
LGTM.
6 years, 5 months ago (2014-07-09 09:04:18 UTC) #2
ricow1
6 years, 5 months ago (2014-07-09 09:09:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698