ui: Use physical size for gfx::Display on Android if available.

ui: Use physical size for gfx::Display on Android if available.

Use gfx::DeviceDisplayInfo::GetPhysicalDisplayWidth/Height() when
avaialble as this is a more accurate value for display size as
window decorations etc. have not been subtracted.

BUG=365877
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282541

[oshima, 2014-07-09 17:44:33]

lgtm with a nit

https://codereview.chromium.org/374303002/diff/1/ui/gfx/screen_android.cc
File ui/gfx/screen_android.cc (right):

https://codereview.chromium.org/374303002/diff/1/ui/gfx/screen_android.cc#new...
ui/gfx/screen_android.cc:38: ? device_info.GetPhysicalDisplayWidth()
It's not your fault, but the name "Physical" sounds a bit misleading. Both are
physical (in pixels), but the difference is that whether or not it includes
system decor area.

Can you add comment and explain the difference?

[reveman, 2014-07-09 18:51:41]

https://codereview.chromium.org/374303002/diff/1/ui/gfx/screen_android.cc
File ui/gfx/screen_android.cc (right):

https://codereview.chromium.org/374303002/diff/1/ui/gfx/screen_android.cc#new...
ui/gfx/screen_android.cc:38: ? device_info.GetPhysicalDisplayWidth()
On 2014/07/09 17:44:33, oshima wrote:
> It's not your fault, but the name "Physical" sounds a bit misleading. Both are
> physical (in pixels), but the difference is that whether or not it includes
> system decor area.
> 
> Can you add comment and explain the difference?

Done.

[reveman, 2014-07-09 18:51:46]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-07-09 18:53:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reveman@chromium.org/374303002/20001

[commit-bot: I haz the power, 2014-07-09 22:09:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-07-09 23:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-09 23:23:36]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[reveman, 2014-07-10 16:26:17]

+boliu@ +mnaganov@ for review of android_webview change

[mnaganov (inactive), 2014-07-10 16:30:16]

lgtm

[reveman, 2014-07-10 23:42:20]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-07-10 23:43:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reveman@chromium.org/374303002/60001

[commit-bot: I haz the power, 2014-07-11 04:46:01]

Change committed as 282541