Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 374283002: Remove the WM_SYSCOMMAND handling from the LegacyRenderWidgetHostHWND class. (Closed)

Created:
6 years, 5 months ago by ananta
Modified:
6 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina
Project:
chromium
Visibility:
Public.

Description

Remove the WM_SYSCOMMAND handling from the LegacyRenderWidgetHostHWND class. This handler was added to forward the message to the parent window for cases where the size of the parent and the LegacyRenderWidgetHostHWND window were the same. We can directly call DefWindowProc on the parent window for non client mouse messages which generates WM_SYSCOMMAND for the parent window. This simplifies the LegacyRenderWidgetHostHWND class and also fixes bugs with WM_SYSCOMMAND messages not getting generated correctly due to missing styles on the LegacyRenderWidgetHostHWND hwnd which does not have the same styles as the parent. BUG=377367 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M content/browser/renderer_host/legacy_render_widget_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M ui/base/win/window_event_target.h View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ananta
6 years, 5 months ago (2014-07-09 02:15:53 UTC) #1
ananta
+sky
6 years, 5 months ago (2014-07-09 02:23:17 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 5 months ago (2014-07-09 18:00:35 UTC) #3
sky
LGTM
6 years, 5 months ago (2014-07-09 23:06:37 UTC) #4
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 5 months ago (2014-07-09 23:11:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/374283002/1
6 years, 5 months ago (2014-07-09 23:13:55 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 04:11:50 UTC) #7
Message was sent while issue was closed.
Change committed as 282248

Powered by Google App Engine
This is Rietveld 408576698