Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 374233003: Roll pdfium. This brings in: (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
palmer, inferno
CC:
chromium-reviews, aarya
Project:
chromium
Visibility:
Public.

Description

Roll pdfium. This brings in: cb46ea1 Fix BUILD.gn for commit 3522876d. ab99c38 Revert 95c018e. 95c018e Fixes for re-enabling more MSVC level 4 warnings. 3522876 Remove custom memory manager. e7ee98e Fix for UMR in CXML_Parser::GetCharRef. 30f2ff1 Fix integer overflow in fx_basic_[bw]string.cpp. d7db790 Fix a crasher issue due to invalid 'bits per component' in PDF. a26b328 fix a crash issue in _CMapLookupCallback. f3227ae Fix uninitialized nresults and RGB. e644f7f Fix uninitialized offset. 5a5c042 Fix uninitialized RGB in GetRGB. 17dd07a Fix uninitialized RGB in translating scanline. ab4221c Integer overflow in fx_basic.h and fx_memory.h. c7d8739 Fix uninitialized RGB in LoadPalette. cceb554 Fix uninitialized font_offset. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281993

Patch Set 1 #

Patch Set 2 : Roll DEPS further forward to fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-08 23:35:09 UTC) #1
aarya
On 2014/07/08 23:35:09, Lei Zhang wrote: Already in progress in https://codereview.chromium.org/378973002/
6 years, 5 months ago (2014-07-08 23:47:50 UTC) #2
Lei Zhang
On 2014/07/08 23:47:50, aarya wrote: > On 2014/07/08 23:35:09, Lei Zhang wrote: > > Already ...
6 years, 5 months ago (2014-07-09 00:09:19 UTC) #3
inferno
lgtm
6 years, 5 months ago (2014-07-09 00:10:49 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-09 00:52:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/374233003/20001
6 years, 5 months ago (2014-07-09 00:54:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 06:40:36 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 08:12:16 UTC) #8
Message was sent while issue was closed.
Change committed as 281993

Powered by Google App Engine
This is Rietveld 408576698