Issue 374213002: Replace deps with depsformat in GN tool defs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 374213002: Replace deps with depsformat in GN tool defs (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
noelallen1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace deps with depsformat in GN tool defs This variable changed name to avoid ambiguity with dependencies. R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282077

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	build/toolchain/gcc_toolchain.gni	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/toolchain/mac/BUILD.gn	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	build/toolchain/nacl/BUILD.gn	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/toolchain/win/BUILD.gn	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

noelallen1

Missing one, otherwise LGTM. https://codereview.chromium.org/374213002/diff/1/build/toolchain/mac/BUILD.gn File build/toolchain/mac/BUILD.gn (right): https://codereview.chromium.org/374213002/diff/1/build/toolchain/mac/BUILD.gn#newcode74 build/toolchain/mac/BUILD.gn:74: deps = "gcc" Missed this ...

6 years, 5 months ago (2014-07-08 21:54:39 UTC) #2

brettw

6 years, 5 months ago (2014-07-09 17:30:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r282077 (presubmit successful).

Expand Messages | Collapse Messages

Issue 374213002: Replace deps with depsformat in GN tool defs (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages