Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 374203003: Invoke the seek callback during abort if needed. (Closed)

Created:
6 years, 5 months ago by damienv1
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Invoke the seek callback during abort if needed. BUG=392281 TEST=ChunkDemuxerTest.SeekCompleteDuringAbort Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281965

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M media/filters/chunk_demuxer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +39 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
damienv1
Please take a look. Thanks.
6 years, 5 months ago (2014-07-08 21:16:20 UTC) #1
damienv1
Note: I used the exact same logic as what is done in ChunkDemuxer::AppendData. However, I ...
6 years, 5 months ago (2014-07-08 21:18:39 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
6 years, 5 months ago (2014-07-08 22:06:31 UTC) #3
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 5 months ago (2014-07-08 23:17:40 UTC) #4
damienv1
The CQ bit was unchecked by damienv@chromium.org
6 years, 5 months ago (2014-07-08 23:18:11 UTC) #5
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 5 months ago (2014-07-09 01:04:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/374203003/1
6 years, 5 months ago (2014-07-09 01:06:09 UTC) #7
commit-bot: I haz the power
Change committed as 281965
6 years, 5 months ago (2014-07-09 05:52:51 UTC) #8
wolenetz
6 years, 5 months ago (2014-07-12 00:06:32 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/374203003/diff/1/media/filters/chunk_demuxer_...
File media/filters/chunk_demuxer_unittest.cc (right):

https://codereview.chromium.org/374203003/diff/1/media/filters/chunk_demuxer_...
media/filters/chunk_demuxer_unittest.cc:2976: 
Hmm. Reviewing this post-commit, but it looks like we never verify the following
here:
1. Seek should not immediately complete
2. Seek should complete after the Abort(), below.

See AppendDataAfterSeek test for one example of how to do this verification.

Best for a separate CL at this point - sorry for belated CR comment on this one.

Powered by Google App Engine
This is Rietveld 408576698