Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tools/perf/benchmarks/peacekeeper.py

Issue 374203002: Update peacekeeper to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/peacekeeper.py
diff --git a/tools/perf/benchmarks/peacekeeper.py b/tools/perf/benchmarks/peacekeeper.py
index 45d9cfbd1de7aa8e66e3fff50502cdbbef98242f..03144ba52d9b83c02c9c5f1f48112a1746ed7606 100644
--- a/tools/perf/benchmarks/peacekeeper.py
+++ b/tools/perf/benchmarks/peacekeeper.py
@@ -21,6 +21,7 @@ from telemetry.util import statistics
from telemetry.value import merge_values
from telemetry.value import scalar
+
class _PeaceKeeperMeasurement(page_measurement.PageMeasurement):
def WillNavigateToPage(self, page, tab):
@@ -54,8 +55,9 @@ class _PeaceKeeperMeasurement(page_measurement.PageMeasurement):
tab.WaitForJavaScriptExpression('_done', 600)
result = tab.EvaluateJavaScript('__results')
- results.Add('Score', 'score', int(result['score']), result['test'],
- 'unimportant')
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, '%s.Score' % result['test'], 'score',
+ int(result['score'])), important=False)
def DidRunTest(self, browser, results):
# Calculate geometric mean as the total for the combined tests.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698