gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt - Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

Issue 374193002: gpu: Optimize and cleanup code used for CHROMIUM_copy_texture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify format selecting logic and support GL_BGRA_EXT Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/android_video_decode_accelerator.cc ('k') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h » ('j') | gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

index 4431e4938fa5da651cf56b860f642fe8e72ba2fc..f9edc0d6c94a1e0930c0a5f02e812b2fa3f63f30 100644

--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

@@ -47,7 +47,18 @@ New Procedures and Functions

destination texture. The level parameter must be 0 at present.

The internal format of the destination texture is converted to that

- specified by <internal_format>.

+ specified by <internal_format>. Must be one of the following symbolic

+ constants: GL_ALPHA, GL_LUMINANCE, GL_LUMINANCE_ALPHA, GL_RGB, GL_RGBA

+ When <source_id> texture doens't contain a superset of the component

+ required by <internal_format>, fill the components by following rules.

+ source format color components

+ =================================================

+ GL_ALPHA (0, 0, 0, A)

+ GL_LUMINANCE (L, L, L, 1)

+ GL_LUMINANCE_ALPHA (L, L, L, A)

+ GL_RGB (R, G, B, 1)

+ GL_RGBA (R, G, B, A)

reveman 2014/08/11 20:48:46 nit: please use spaces instead of tabs.

dshwang 2014/08/12 07:03:01 Done.

The format type of the destination texture is converted to that specified

by <dest_type>.