gpu: Optimize and cleanup code used for CHROMIUM_copy_texture.

content/common/gpu/media/android_video_decode_accelerator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/android_video_decode_accelerator.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 339 matching lines @@
     copier_->Initialize(gl_decoder_.get());
   }
 
   // Here, we copy |surface_texture_id_| to the picture buffer instead of
   // setting new texture to |surface_texture_| by calling attachToGLContext()
   // because:
   // 1. Once we call detachFrameGLContext(), it deletes the texture previous
   //    attached.
   // 2. SurfaceTexture requires us to apply a transform matrix when we show
   //    the texture.
-  copier_->DoCopyTexture(gl_decoder_.get(), GL_TEXTURE_EXTERNAL_OES,
-                         GL_TEXTURE_2D, surface_texture_id_,
-                         picture_buffer_texture_id, 0, size_.width(),
-                         size_.height(), false, false, false);
+  // TODO(hkuang): get the StreamTexture transform matrix in GPU process
+  // instead of using default matrix crbug.com/226218.
+  const static GLfloat default_matrix[16] = {1.0f, 0.0f, 0.0f, 0.0f,
+                                             0.0f, 1.0f, 0.0f, 0.0f,
+                                             0.0f, 0.0f, 1.0f, 0.0f,
+                                             0.0f, 0.0f, 0.0f, 1.0f};
+  copier_->DoCopyTextureWithTransform(gl_decoder_.get(),

[dshwang, 2014/07/10 22:08:22]

I changed here like gles2_cmd_decoder. Could you review here again?
hkuang@, I added TODO same to comment in gles2_cmd_decoder.

+                                      GL_TEXTURE_EXTERNAL_OES,
+                                      surface_texture_id_,
+                                      picture_buffer_texture_id,
+                                      0,
+                                      size_.width(),
+                                      size_.height(),
+                                      false,
+                                      false,
+                                      false,
+                                      default_matrix);
 
   base::MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(&AndroidVideoDecodeAccelerator::NotifyPictureReady,
                  weak_this_factory_.GetWeakPtr(),
                  media::Picture(picture_buffer_id, bitstream_id)));
 }
 
 void AndroidVideoDecodeAccelerator::Decode(
     const media::BitstreamBuffer& bitstream_buffer) {
@@ skipping 165 matching lines @@
 void AndroidVideoDecodeAccelerator::NotifyResetDone() {
   client_->NotifyResetDone();
 }
 
 void AndroidVideoDecodeAccelerator::NotifyError(
     media::VideoDecodeAccelerator::Error error) {
   client_->NotifyError(error);
 }
 
 }  // namespace content