Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc

Issue 374183003: Two fixes regarding to bookmark backup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/internal_api/sync_backup_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc
diff --git a/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc b/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc
index f545aaa444bcf856eccaaf2ca7f0ce2d39d149cd..3321669b1f7c21c7665d5bfecb4640d4bbe3ec9e 100644
--- a/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc
+++ b/chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc
@@ -24,6 +24,12 @@ using bookmarks_helper::Move;
using bookmarks_helper::Remove;
using sync_integration_test_util::AwaitCommitActivityCompletion;
+namespace {
+const char kUrl1[] = "http://www.google.com";
+const char kUrl2[] = "http://map.google.com";
+const char kUrl3[] = "http://plus.google.com";
+} // anonymous namespace
+
class SingleClientBackupRollbackTest : public SyncTest {
public:
SingleClientBackupRollbackTest() : SyncTest(SINGLE_CLIENT) {}
@@ -222,10 +228,6 @@ IN_PROC_BROWSER_TEST_F(SingleClientBackupRollbackTest,
MAYBE_TestPrefBackupRollback) {
EnableRollback();
- const char kUrl1[] = "http://www.google.com";
- const char kUrl2[] = "http://map.google.com";
- const char kUrl3[] = "http://plus.google.com";
-
ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
preferences_helper::ChangeStringPref(0, prefs::kHomePage, kUrl1);
@@ -306,3 +308,33 @@ IN_PROC_BROWSER_TEST_F(SingleClientBackupRollbackTest,
ASSERT_EQ(GURL("http://www.nhl.com"),
GetOtherNode(0)->GetChild(0)->url());
}
+
+#if defined(ENABLE_PRE_SYNC_BACKUP)
+#define MAYBE_DontChangeBookmarkOrdering DontChangeBookmarkOrdering
+#else
+#define MAYBE_DontChangeBookmarkOrdering DISABLED_DontChangeBookmarkOrdering
+#endif
+IN_PROC_BROWSER_TEST_F(SingleClientBackupRollbackTest,
+ MAYBE_DontChangeBookmarkOrdering) {
+ ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";
+
+ const BookmarkNode* sub_folder = AddFolder(0, GetOtherNode(0), 0, "test");
+ ASSERT_TRUE(AddURL(0, sub_folder, 0, "", GURL(kUrl1)));
+ ASSERT_TRUE(AddURL(0, sub_folder, 1, "", GURL(kUrl2)));
+ ASSERT_TRUE(AddURL(0, sub_folder, 2, "", GURL(kUrl3)));
+
+ BackupModeChecker checker(GetSyncService(0),
+ base::TimeDelta::FromSeconds(15));
+ ASSERT_TRUE(checker.Wait());
+
+ // Restart backup.
+ GetSyncService(0)->StartStopBackupForTesting();
+ GetSyncService(0)->StartStopBackupForTesting();
+ ASSERT_TRUE(checker.Wait());
+
+ // Verify bookmarks are unchanged.
+ ASSERT_EQ(3, sub_folder->child_count());
+ ASSERT_EQ(GURL(kUrl1), sub_folder->GetChild(0)->url());
+ ASSERT_EQ(GURL(kUrl2), sub_folder->GetChild(1)->url());
+ ASSERT_EQ(GURL(kUrl3), sub_folder->GetChild(2)->url());
+}
« no previous file with comments | « no previous file | sync/internal_api/sync_backup_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698