Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 374183003: Two fixes regarding to bookmark backup (Closed)

Created:
6 years, 5 months ago by haitaol1
Modified:
6 years, 5 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Two fixes regarding to bookmark backup * Only change parent id when normalizing entry. Use PutParentIdPropertyOnly() instead of PutParentId() because the latter resets predecessor and changes ordering. * Don't create sync node for mobile bookmarks, which only exists with sync enabled. BUG=385731 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281926

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : ToT #

Patch Set 4 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 1 2 3 chunks +36 lines, -4 lines 0 comments Download
M sync/internal_api/sync_backup_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
haitaol1
6 years, 5 months ago (2014-07-08 19:09:03 UTC) #1
rlarocque
lgtm
6 years, 5 months ago (2014-07-08 19:21:23 UTC) #2
rlarocque
By the way, the commit message is not quite correct. The commit bot will only ...
6 years, 5 months ago (2014-07-08 19:22:19 UTC) #3
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 5 months ago (2014-07-08 20:58:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/374183003/80001
6 years, 5 months ago (2014-07-08 21:01:32 UTC) #5
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 5 months ago (2014-07-08 21:50:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/374183003/100001
6 years, 5 months ago (2014-07-08 21:55:07 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:25:05 UTC) #8
Message was sent while issue was closed. 
Change committed as 281926

Powered by Google App Engine
This is Rietveld 408576698