Hook up the default v8::Platform implementation to pdfium

Hook up the default v8::Platform implementation to pdfium

It remains to call the PumpMessageLoop() method at a regular interval,
however, since nothing posts to the loop yet, that shouldn't be a
problem.

BUG=pdfium:25
R=jam@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3fb18f4

[jam, 2014-07-14 23:06:17]

can you provide more background (bug?) about the motivation for this cl? since
I'm unfamiliar with v8, I don't know what are the benefits of doing this.

[jam, 2014-07-14 23:06:22]

https://codereview.chromium.org/374123002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/374123002/diff/1/BUILD.gn#newcode809
BUILD.gn:809: "//v8",
tiny nit: here and below, and also in the gyp files, i think it's more common to
flip the order so that "//v8" is before "//v8/include"?

https://codereview.chromium.org/374123002/diff/1/fpdfsdk/include/jsapi/fxjs_v8.h
File fpdfsdk/include/jsapi/fxjs_v8.h (right):

https://codereview.chromium.org/374123002/diff/1/fpdfsdk/include/jsapi/fxjs_v...
fpdfsdk/include/jsapi/fxjs_v8.h:11: #include <v8-platform.h>
why is this needed in this header?

[jochen (gone - plz use gerrit), 2014-07-15 11:51:09]

all comments addressed.

https://codereview.chromium.org/374123002/diff/1/fpdfsdk/include/jsapi/fxjs_v8.h
File fpdfsdk/include/jsapi/fxjs_v8.h (right):

https://codereview.chromium.org/374123002/diff/1/fpdfsdk/include/jsapi/fxjs_v...
fpdfsdk/include/jsapi/fxjs_v8.h:11: #include <v8-platform.h>
it's not really needed here, but it's the only file that include v8.h, so I
thought I'd put the include here as well.

[jam, 2014-07-15 16:25:26]

lgtm

https://codereview.chromium.org/374123002/diff/1/fpdfsdk/include/jsapi/fxjs_v8.h
File fpdfsdk/include/jsapi/fxjs_v8.h (right):

https://codereview.chromium.org/374123002/diff/1/fpdfsdk/include/jsapi/fxjs_v...
fpdfsdk/include/jsapi/fxjs_v8.h:11: #include <v8-platform.h>
On 2014/07/15 11:51:09, jochen wrote:
> it's not really needed here, but it's the only file that include v8.h, so I
> thought I'd put the include here as well.

I think we should only add headers that we need, so I'd prefer removing it and
adding it in whatever headers need it in the future

[jochen (gone - plz use gerrit), 2014-07-17 06:46:51]

Committed patchset #3 manually as r3fb18f4 (presubmit successful).

[Lei Zhang, 2014-08-01 06:51:23]

https://codereview.chromium.org/374123002/diff/40001/fpdfsdk/src/javascript/J...
File fpdfsdk/src/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/374123002/diff/40001/fpdfsdk/src/javascript/J...
fpdfsdk/src/javascript/JS_Runtime.cpp:42:
v8::V8::InitializePlatform(m_platform);
With component builds on Linux, when loading PDFs that call
FORM_DoDocumentJSAction(), InitializePlatform() fails an ASSERT() because
InitializePlatform() has already been caller in Webkit.cpp.

[jochen (gone - plz use gerrit), 2014-08-01 06:56:48]

Yes, that's on purpose.

PDFium doesn't work with a components build.