Issue 374103002: Change some names in Promise instrumentation events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 374103002: Change some names in Promise instrumentation events. (Closed)

Created:
6 years, 5 months ago by aandrey

Modified:
6 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Change some names in Promise instrumentation events. TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22284

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/promise.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/mjsunit/es6/debug-promises-async-task-event.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

aandrey

Committed patchset #1 manually as r22284 (presubmit successful).

6 years, 5 months ago (2014-07-08 14:46:07 UTC) #2

Yang

6 years, 5 months ago (2014-07-08 15:09:35 UTC) #3

Message was sent while issue was closed.

On 2014/07/08 14:46:07, aandrey wrote:
> Committed patchset #1 manually as r22284 (presubmit successful).

LGTM. But please do not use TBR for changes that are not time-critical.

Expand Messages | Collapse Messages