Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml

Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix layout test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml
diff --git a/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml b/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml
index 56f3542a675b3c6da5d3d184ca9341728fa2e6e3..e61f81c83ec5472c55f3834aeb80bb50f0427e17 100644
--- a/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml
+++ b/LayoutTests/fast/dom/processing-instruction-appendChild-exceptions.xhtml
@@ -5,7 +5,7 @@
<![CDATA[
description("Test that appropriate exceptions are thrown when adding children to a ProcessingInstruction.");
var pi = document.createProcessingInstruction('target', 'data');
-shouldThrow("pi.appendChild(null)", '"HierarchyRequestError: Failed to execute \'appendChild\' on \'Node\': This node type does not support this method."');
+shouldThrow("pi.appendChild(null)", '"TypeError: Failed to execute \'appendChild\' on \'Node\': parameter 1 is not of type \'Node\'."');
var div = document.createElement('div');
shouldThrow("pi.appendChild(div)", '"HierarchyRequestError: Failed to execute \'appendChild\' on \'Node\': This node type does not support this method."');
var textNode = document.createTextNode('sometext');

Powered by Google App Engine
This is Rietveld 408576698