Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: LayoutTests/fast/dom/incompatible-operations.html

Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix layout test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/dom/incompatible-operations-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/dom/incompatible-operations.html
diff --git a/LayoutTests/fast/dom/incompatible-operations.html b/LayoutTests/fast/dom/incompatible-operations.html
index d79f94d4b1f6c57d10b339c2158d248f91e26a7a..7fca59c213a6ab4de79f8fea09b1db460645eab0 100644
--- a/LayoutTests/fast/dom/incompatible-operations.html
+++ b/LayoutTests/fast/dom/incompatible-operations.html
@@ -28,11 +28,11 @@ var aNode = document.createElement("div");
var aSecondNode = document.createElement("div");
aNode.appendChild(aSecondNode);
-shouldThrow("aNode.appendChild(aDOMImplementation)", '"NotFoundError: Failed to execute \'appendChild\' on \'Node\': The new child element is null."');
+shouldThrow("aNode.appendChild(aDOMImplementation)", '"TypeError: Failed to execute \'appendChild\' on \'Node\': parameter 1 is not of type \'Node\'."');
-shouldThrow("aNode.appendChild('knort')", '"NotFoundError: Failed to execute \'appendChild\' on \'Node\': The new child element is null."');
+shouldThrow("aNode.appendChild('knort')", '"TypeError: Failed to execute \'appendChild\' on \'Node\': parameter 1 is not of type \'Node\'."');
-shouldThrow("aNode.appendChild(void 0)", '"NotFoundError: Failed to execute \'appendChild\' on \'Node\': The new child element is null."');
+shouldThrow("aNode.appendChild(void 0)", '"TypeError: Failed to execute \'appendChild\' on \'Node\': parameter 1 is not of type \'Node\'."');
shouldBeFalse("aNode.isSameNode(aDOMImplementation)");
shouldBeFalse("aNode.isSameNode('foo')");
« no previous file with comments | « no previous file | LayoutTests/fast/dom/incompatible-operations-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698