LayoutTests/fast/dom/incompatible-operations-expected.txt - Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/incompatible-operations-expected.txt

Issue 374093002: Node.appendChild should throw TypeError when newChild is not an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/incompatible-operations.html ('k') | LayoutTests/fast/dom/move-nodes-across-documents.html » ('j') | Source/bindings/core/v8/custom/V8NodeCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/incompatible-operations-expected.txt

diff --git a/LayoutTests/fast/dom/incompatible-operations-expected.txt b/LayoutTests/fast/dom/incompatible-operations-expected.txt

index dd27a04ef27bad85eaa973bfd18c36f3dd1d048e..f582a0ee9f2aad6caa52476fa7ff19d910940a45 100644

--- a/LayoutTests/fast/dom/incompatible-operations-expected.txt

+++ b/LayoutTests/fast/dom/incompatible-operations-expected.txt

@@ -4,8 +4,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

PASS aNode.appendChild(aDOMImplementation) threw exception NotFoundError: Failed to execute 'appendChild' on 'Node': The new child element is null..

-PASS aNode.appendChild('knort') threw exception NotFoundError: Failed to execute 'appendChild' on 'Node': The new child element is null..

-PASS aNode.appendChild(void 0) threw exception NotFoundError: Failed to execute 'appendChild' on 'Node': The new child element is null..

+PASS aNode.appendChild('knort') threw exception TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 ('newChild') is not an object..

+PASS aNode.appendChild(void 0) threw exception TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 ('newChild') is not an object..

PASS aNode.isSameNode(aDOMImplementation) is false

PASS aNode.isSameNode('foo') is false

PASS aNode.isSameNode(void 0) is false