Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: Source/platform/mhtml/ArchiveResource.h

Issue 374053002: Oilpan: move MHTML objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make MHTMLArchive.h self-contained/closed. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | Source/platform/mhtml/ArchiveResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/mhtml/ArchiveResource.h
diff --git a/Source/platform/mhtml/ArchiveResource.h b/Source/platform/mhtml/ArchiveResource.h
index 3bfde70511e2321cdab93a5b9fae687a2d660018..5050bdb4073f3da2041709f3fc1506f87700819d 100644
--- a/Source/platform/mhtml/ArchiveResource.h
+++ b/Source/platform/mhtml/ArchiveResource.h
@@ -30,6 +30,7 @@
#define ArchiveResource_h
#include "platform/SharedBuffer.h"
+#include "platform/heap/Handle.h"
#include "platform/network/ResourceResponse.h"
#include "platform/weborigin/KURL.h"
#include "wtf/RefCounted.h"
@@ -37,13 +38,15 @@
namespace WebCore {
-class PLATFORM_EXPORT ArchiveResource : public RefCounted<ArchiveResource> {
+class PLATFORM_EXPORT ArchiveResource FINAL : public RefCountedWillBeGarbageCollectedFinalized<ArchiveResource> {
public:
- static PassRefPtr<ArchiveResource> create(PassRefPtr<SharedBuffer>, const KURL&, const ResourceResponse&);
- static PassRefPtr<ArchiveResource> create(PassRefPtr<SharedBuffer>, const KURL&,
+ static PassRefPtrWillBeRawPtr<ArchiveResource> create(PassRefPtr<SharedBuffer>, const KURL&, const ResourceResponse&);
+ static PassRefPtrWillBeRawPtr<ArchiveResource> create(PassRefPtr<SharedBuffer>, const KURL&,
const AtomicString& mimeType, const AtomicString& textEncoding, const String& frameName,
const ResourceResponse& = ResourceResponse());
+ ~ArchiveResource();
+
const KURL& url() const { return m_url; }
const ResourceResponse& response() const { return m_response; }
SharedBuffer* data() const { return m_data.get(); }
@@ -51,6 +54,8 @@ public:
const AtomicString& textEncoding() const { return m_textEncoding; }
const String& frameName() const { return m_frameName; }
+ void trace(Visitor*) { }
+
private:
ArchiveResource(PassRefPtr<SharedBuffer>, const KURL&, const AtomicString& mimeType, const AtomicString& textEncoding, const String& frameName, const ResourceResponse&);
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | Source/platform/mhtml/ArchiveResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698