Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/web/WebPageSerializer.cpp

Issue 374053002: Oilpan: move MHTML objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Conditionally provide clear methods over MHTMLArchive Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/mhtml/MHTMLParser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 #include "core/frame/LocalFrame.h" 37 #include "core/frame/LocalFrame.h"
38 #include "core/html/HTMLAllCollection.h" 38 #include "core/html/HTMLAllCollection.h"
39 #include "core/html/HTMLFrameElementBase.h" 39 #include "core/html/HTMLFrameElementBase.h"
40 #include "core/html/HTMLFrameOwnerElement.h" 40 #include "core/html/HTMLFrameOwnerElement.h"
41 #include "core/html/HTMLInputElement.h" 41 #include "core/html/HTMLInputElement.h"
42 #include "core/html/HTMLTableElement.h" 42 #include "core/html/HTMLTableElement.h"
43 #include "core/loader/DocumentLoader.h" 43 #include "core/loader/DocumentLoader.h"
44 #include "core/page/Page.h" 44 #include "core/page/Page.h"
45 #include "core/page/PageSerializer.h" 45 #include "core/page/PageSerializer.h"
46 #include "platform/SerializedResource.h" 46 #include "platform/SerializedResource.h"
47 #include "platform/mhtml/ArchiveResource.h"
tkent 2014/07/09 01:04:34 Why do we need to include it? It seems ArchiveReso
sof 2014/07/09 04:42:19 MHTMLArchive inlines a vector append() so as to re
tkent 2014/07/09 04:49:24 I see. So this include looks wrong to me. Please
sof 2014/07/09 05:11:20 Yes, removed. To make MHTMLArchive.h closed, I mov
47 #include "platform/mhtml/MHTMLArchive.h" 48 #include "platform/mhtml/MHTMLArchive.h"
48 #include "platform/weborigin/KURL.h" 49 #include "platform/weborigin/KURL.h"
49 #include "public/platform/WebCString.h" 50 #include "public/platform/WebCString.h"
50 #include "public/platform/WebString.h" 51 #include "public/platform/WebString.h"
51 #include "public/platform/WebURL.h" 52 #include "public/platform/WebURL.h"
52 #include "public/platform/WebVector.h" 53 #include "public/platform/WebVector.h"
53 #include "public/web/WebFrame.h" 54 #include "public/web/WebFrame.h"
54 #include "public/web/WebPageSerializerClient.h" 55 #include "public/web/WebPageSerializerClient.h"
55 #include "public/web/WebView.h" 56 #include "public/web/WebView.h"
56 #include "web/WebLocalFrameImpl.h" 57 #include "web/WebLocalFrameImpl.h"
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 265
265 WebString WebPageSerializer::generateBaseTagDeclaration(const WebString& baseTar get) 266 WebString WebPageSerializer::generateBaseTagDeclaration(const WebString& baseTar get)
266 { 267 {
267 if (baseTarget.isEmpty()) 268 if (baseTarget.isEmpty())
268 return String("<base href=\".\">"); 269 return String("<base href=\".\">");
269 String baseString = "<base href=\".\" target=\"" + static_cast<const String& >(baseTarget) + "\">"; 270 String baseString = "<base href=\".\" target=\"" + static_cast<const String& >(baseTarget) + "\">";
270 return baseString; 271 return baseString;
271 } 272 }
272 273
273 } // namespace blink 274 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/mhtml/MHTMLParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698