Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 374024: Allow return key to add new line in description text field.... (Closed)

Created:
11 years, 1 month ago by Miranda Callahan
Modified:
9 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Allow return key to add new line in description text field. BUG=26860 TEST= open bug report. enter multi-line description, using return to insert newlines. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31388

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M chrome/app/nibs/ReportBug.xib View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bug_report_window_controller.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bug_report_window_controller.mm View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Miranda Callahan
11 years, 1 month ago (2009-11-07 01:33:40 UTC) #1
John Grabowski
LGTM http://codereview.chromium.org/374024/diff/2001/2003 File chrome/browser/cocoa/bug_report_window_controller.h (right): http://codereview.chromium.org/374024/diff/2001/2003#newcode79 Line 79: // within the description field. Please also ...
11 years, 1 month ago (2009-11-07 01:51:22 UTC) #2
Miranda Callahan
11 years, 1 month ago (2009-11-07 16:24:36 UTC) #3
http://codereview.chromium.org/374024/diff/2001/2003
File chrome/browser/cocoa/bug_report_window_controller.h (right):

http://codereview.chromium.org/374024/diff/2001/2003#newcode79
Line 79: // within the description field.
On 2009/11/07 01:51:22, John Grabowski wrote:
> Please also briefly describe default behavior (e.g. "... instead of sending
the
> action method")
> 

Done.

http://codereview.chromium.org/374024/diff/2001/2004
File chrome/browser/cocoa/bug_report_window_controller.mm (right):

http://codereview.chromium.org/374024/diff/2001/2004#newcode132
Line 132: - (void)menu:(NSMenu*)menu willHighlightItem:(NSMenuItem *)item {
On 2009/11/07 01:51:22, John Grabowski wrote:
> Since you're fixing one, can you fix the other?
> 
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698