Issue 373973003: Gin: Allow multiple callers to wait for the same module in ModuleRegistry.

Issue 373973003: Gin: Allow multiple callers to wait for the same module in ModuleRegistry. (Closed)

Created:
6 years, 5 months ago by Sam McNally

Modified:
6 years, 5 months ago

Reviewers:
abarth-chromium

CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Gin: Allow multiple callers to wait for the same module in ModuleRegistry. BUG=391888 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281966

Patch Set 2 : callbacks.reserve() #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -11 lines)			Patch
M	gin/modules/module_registry.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gin/modules/module_registry.cc	View	1	2 chunks	+16 lines, -10 lines	0 comments	Download
M	gin/modules/module_registry_unittest.cc	View		3 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM https://codereview.chromium.org/373973003/diff/20001/gin/modules/module_registry.cc File gin/modules/module_registry.cc (right): https://codereview.chromium.org/373973003/diff/20001/gin/modules/module_registry.cc#newcode187 gin/modules/module_registry.cc:187: std::vector<LoadModuleCallback> callbacks; Can you preallocate the correct number ...

6 years, 5 months ago (2014-07-08 14:20:30 UTC) #2

Sam McNally

https://codereview.chromium.org/373973003/diff/20001/gin/modules/module_registry.cc File gin/modules/module_registry.cc (right): https://codereview.chromium.org/373973003/diff/20001/gin/modules/module_registry.cc#newcode187 gin/modules/module_registry.cc:187: std::vector<LoadModuleCallback> callbacks; On 2014/07/08 14:20:30, abarth wrote: > Can ...

6 years, 5 months ago (2014-07-09 00:22:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/373973003/40001

6 years, 5 months ago (2014-07-09 01:21:32 UTC) #5

Message was sent while issue was closed.

Change committed as 281966

Expand Messages | Collapse Messages