Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 373973002: Set CONFIGURATION_NAME to be used in base.isolate. (Closed)

Created:
6 years, 5 months ago by scheib
Modified:
6 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Set CONFIGURATION_NAME to be used in base.isolate. Enables precise control of the isolate depending on correct versions of msvc*.dll. BUG=390686 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M base/base.isolate View 1 chunk +11 lines, -7 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/isolate.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheib
I've tested on windows with: 1. ninja -C out\Release browser_tests_run 2. python tools\swarming_client\isolate.py run -s ...
6 years, 5 months ago (2014-07-08 00:18:59 UTC) #1
M-A Ruel
On 2014/07/08 00:18:59, scheib wrote: > I've tested on windows with: > 1. ninja -C ...
6 years, 5 months ago (2014-07-08 11:52:58 UTC) #2
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 5 months ago (2014-07-08 11:53:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/373973002/1
6 years, 5 months ago (2014-07-08 11:53:49 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 12:46:17 UTC) #5
Message was sent while issue was closed.
Change committed as 281730

Powered by Google App Engine
This is Rietveld 408576698