Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 373923002: Only count non-default apps against first time sync (Closed)

Created:
6 years, 5 months ago by stevenjb
Modified:
6 years, 5 months ago
Reviewers:
jennyz, dpolukhin
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Only count non-default apps against first time sync The OOBE process may install some default apps. We need to ignore these when determining whether or not any apps have been synched when determining the OEM folder position. BUG=chrome-os-partner:29764, chromium:391683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 6 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
OK, this CL passes the OOBE test for OEM folder position, PTAL when you can, ...
6 years, 5 months ago (2014-07-07 23:17:23 UTC) #1
jennyz
lgtm
6 years, 5 months ago (2014-07-08 17:30:23 UTC) #2
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 5 months ago (2014-07-08 18:42:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/373923002/1
6 years, 5 months ago (2014-07-08 18:45:30 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 23:40:26 UTC) #5
Message was sent while issue was closed.
Change committed as 281886

Powered by Google App Engine
This is Rietveld 408576698