Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 373873002: Fixes for re-enabling more MSVC level 4 warnings: content/browser/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/p2p/socket_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_internals_ui.cc
diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc
index 8f59ea5a2994d720173bfefba81c3b9e5048555c..d4bc81a09a9b0616a3a19df11343f051c51f5834 100644
--- a/content/browser/service_worker/service_worker_internals_ui.cc
+++ b/content/browser/service_worker/service_worker_internals_ui.cc
@@ -560,11 +560,11 @@ void ServiceWorkerInternalsUI::CallServiceWorkerVersionMethod(
const ListValue* args) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
int callback_id;
- int partition_id;
- int64 version_id;
- std::string version_id_string;
const DictionaryValue* cmd_args = NULL;
+ int partition_id;
scoped_refptr<ServiceWorkerContextWrapper> context;
+ std::string version_id_string;
+ int64 version_id = 0;
if (!args->GetInteger(0, &callback_id) ||
!args->GetDictionary(1, &cmd_args) ||
!cmd_args->GetInteger("partition_id", &partition_id) ||
@@ -585,7 +585,7 @@ void ServiceWorkerInternalsUI::DispatchPushEvent(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
int callback_id;
int partition_id;
- int64 version_id;
+ int64 version_id = 0;
std::string version_id_string;
const DictionaryValue* cmd_args = NULL;
scoped_refptr<ServiceWorkerContextWrapper> context;
@@ -606,10 +606,9 @@ void ServiceWorkerInternalsUI::DispatchPushEvent(
void ServiceWorkerInternalsUI::InspectWorker(const ListValue* args) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
int callback_id;
- int process_id;
- int devtools_agent_route_id;
const DictionaryValue* cmd_args = NULL;
- scoped_refptr<ServiceWorkerContextWrapper> context;
+ int process_id = 0;
+ int devtools_agent_route_id = 0;
if (!args->GetInteger(0, &callback_id) ||
!args->GetDictionary(1, &cmd_args) ||
!cmd_args->GetInteger("process_id", &process_id) ||
« no previous file with comments | « content/browser/renderer_host/p2p/socket_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698