Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 373813002: User manager: fix deleting desktop/managed users with the keyboard (Closed)

Created:
6 years, 5 months ago by noms (inactive)
Modified:
6 years, 5 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

User manager: fix deleting desktop/managed users with the keyboard BUG=390820 TEST=Start chrome with --new-profile-management. Choose "Not <profile>" from the avatar bubble. In the User Manager, press 'tab' until focus reaches the drop down arrow of a user pod. Press 'enter', whcih should show you the delete button. Press the down arrow to focus the delete button, and press 'Enter'. This should show the warning view, with the big red button focused, and pressing 'Enter' again should delete the pod. Yay! Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281852

Patch Set 1 : #

Total comments: 2

Patch Set 2 : refactor removeUser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M chrome/browser/resources/login/user_pod_row.js View 1 6 chunks +45 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
noms (inactive)
Hi Nikita, Fixed an a11y bug in deleting desktop/managed users in the User Manager using ...
6 years, 5 months ago (2014-07-07 17:29:41 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/373813002/diff/20001/chrome/browser/resources/login/user_pod_row.js File chrome/browser/resources/login/user_pod_row.js (right): https://codereview.chromium.org/373813002/diff/20001/chrome/browser/resources/login/user_pod_row.js#newcode880 chrome/browser/resources/login/user_pod_row.js:880: chrome.send('removeUser', nit: Make sense to extract chrome.send('removeUser', ...) ...
6 years, 5 months ago (2014-07-08 11:58:53 UTC) #2
noms (inactive)
https://codereview.chromium.org/373813002/diff/20001/chrome/browser/resources/login/user_pod_row.js File chrome/browser/resources/login/user_pod_row.js (right): https://codereview.chromium.org/373813002/diff/20001/chrome/browser/resources/login/user_pod_row.js#newcode880 chrome/browser/resources/login/user_pod_row.js:880: chrome.send('removeUser', On 2014/07/08 11:58:53, Nikita Kostylev wrote: > nit: ...
6 years, 5 months ago (2014-07-08 14:14:48 UTC) #3
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 5 months ago (2014-07-08 17:03:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/373813002/40001
6 years, 5 months ago (2014-07-08 17:04:30 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 18:15:27 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 22:43:15 UTC) #7
Message was sent while issue was closed.
Change committed as 281852

Powered by Google App Engine
This is Rietveld 408576698