Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 373743003: DevTools: Add support for adding source map to a script from the DevTools window. (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Add support for adding source map to a script from the DevTools window. BUG=330381 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178053

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -49 lines) Patch
M Source/devtools/devtools.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/CompilerScriptMapping.js View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceScriptMapping.js View 6 chunks +17 lines, -41 lines 0 comments Download
M Source/devtools/front_end/sdk/Script.js View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/UISourceCode.js View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
A Source/devtools/front_end/sources/AddSourceMapURLDialog.js View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 4 chunks +34 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vsevik
PTAL See screenshots in the bug.
6 years, 5 months ago (2014-07-07 06:20:50 UTC) #1
lushnikov
https://codereview.chromium.org/373743003/diff/20001/Source/devtools/front_end/sources/JavaScriptSourceFrame.js File Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right): https://codereview.chromium.org/373743003/diff/20001/Source/devtools/front_end/sources/JavaScriptSourceFrame.js#newcode332 Source/devtools/front_end/sources/JavaScriptSourceFrame.js:332: var scriptFile = this._scriptFileForTarget.values()[0]; why for the first script ...
6 years, 5 months ago (2014-07-07 15:34:56 UTC) #2
pfeldman
lgtm
6 years, 5 months ago (2014-07-09 08:40:54 UTC) #3
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-14 11:33:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/373743003/40001
6 years, 5 months ago (2014-07-14 11:34:03 UTC) #5
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-14 11:35:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/373743003/40001
6 years, 5 months ago (2014-07-14 11:35:41 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 13:01:33 UTC) #8
Message was sent while issue was closed. 
Change committed as 178053

Powered by Google App Engine
This is Rietveld 408576698