Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 373743002: [fsp] Extract common code for metadata handling in browser tests. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Extract common code for metadata handling in browser tests. Because most of the browser tests of the File System Provider API need some testing files to work on, there was a lot of duplicated code. This patch extracts the metadata handling code as a default implementation of the onMetadataRequested event. TEST=browser_tests: *FileSystemProvider* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281644

Patch Set 1 #

Messages

Total messages: 7 (0 generated)
mtomasz
@hirono: PTAL. This depends on the previous CL: 374543002. Thanks.
6 years, 5 months ago (2014-07-07 05:27:14 UTC) #1
hirono
lgtm!
6 years, 5 months ago (2014-07-07 05:56:05 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-07 07:23:40 UTC) #3
mtomasz
The CQ bit was unchecked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-07 07:24:01 UTC) #4
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-07 23:26:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/373743002/1
6 years, 5 months ago (2014-07-07 23:28:59 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 02:51:18 UTC) #7
Message was sent while issue was closed.
Change committed as 281644

Powered by Google App Engine
This is Rietveld 408576698