Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 373713003: [ServiceWorker] Fills the referrer of WebServiceWorkerRequest. (Closed)

Created:
6 years, 5 months ago by horo
Modified:
6 years, 5 months ago
Reviewers:
falken, nasko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Fills the referrer of WebServiceWorkerRequest. This change depends on http://crrev.com/329853012 The tests for this change will be added in the LayoutTests of Blink: http://crrev.com/373713004 BUG=373120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282283

Patch Set 1 #

Total comments: 2

Patch Set 2 : GURL #

Patch Set 3 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
horo
falken@ Could you please review?
6 years, 5 months ago (2014-07-07 02:48:17 UTC) #1
falken
https://codereview.chromium.org/373713003/diff/1/content/common/service_worker/service_worker_types.h File content/common/service_worker/service_worker_types.h (right): https://codereview.chromium.org/373713003/diff/1/content/common/service_worker/service_worker_types.h#newcode58 content/common/service_worker/service_worker_types.h:58: std::string referrer; I think this should be a GURL ...
6 years, 5 months ago (2014-07-07 08:17:30 UTC) #2
horo
https://codereview.chromium.org/373713003/diff/1/content/common/service_worker/service_worker_types.h File content/common/service_worker/service_worker_types.h (right): https://codereview.chromium.org/373713003/diff/1/content/common/service_worker/service_worker_types.h#newcode58 content/common/service_worker/service_worker_types.h:58: std::string referrer; On 2014/07/07 08:17:30, falken wrote: > I ...
6 years, 5 months ago (2014-07-07 10:49:15 UTC) #3
falken
lgtm
6 years, 5 months ago (2014-07-08 03:58:42 UTC) #4
horo
nasko@ Could you please review content/common/service_worker/service_worker_messages.h?
6 years, 5 months ago (2014-07-09 04:21:25 UTC) #5
nasko
lgtm
6 years, 5 months ago (2014-07-09 07:13:15 UTC) #6
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-10 01:03:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/373713003/20001
6 years, 5 months ago (2014-07-10 01:06:56 UTC) #8
horo
The CQ bit was unchecked by horo@chromium.org
6 years, 5 months ago (2014-07-10 01:15:49 UTC) #9
horo
The CQ bit was checked by horo@chromium.org
6 years, 5 months ago (2014-07-10 01:57:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/373713003/40001
6 years, 5 months ago (2014-07-10 01:59:19 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:06:55 UTC) #12
Message was sent while issue was closed. 
Change committed as 282283

Powered by Google App Engine
This is Rietveld 408576698