Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix CrOS test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 10f87e7367ae9b1e5988e891b56b88db287f7fb7..37212aed25c4b60da20a8fb2558a3f42ac4557ee 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2368,12 +2368,10 @@ void WebContentsImpl::DidFailLoadWithError(
const GURL& url,
int error_code,
const base::string16& error_description) {
- int render_frame_id = render_frame_host->GetRoutingID();
- bool is_main_frame = render_frame_host->frame_tree_node()->IsMainFrame();
- RenderViewHost* render_view_host = render_frame_host->render_view_host();
- FOR_EACH_OBSERVER(WebContentsObserver, observers_,
- DidFailLoad(render_frame_id, url, is_main_frame, error_code,
- error_description, render_view_host));
+ FOR_EACH_OBSERVER(
+ WebContentsObserver,
+ observers_,
+ DidFailLoad(render_frame_host, url, error_code, error_description));
}
void WebContentsImpl::NotifyChangedNavigationState(
@@ -2595,12 +2593,8 @@ void WebContentsImpl::OnDocumentLoadedInFrame() {
CHECK(!render_view_message_source_);
RenderFrameHostImpl* rfh =
static_cast<RenderFrameHostImpl*>(render_frame_message_source_);
-
- int render_frame_id = rfh->GetRoutingID();
- RenderViewHost* render_view_host = rfh->render_view_host();
- FOR_EACH_OBSERVER(WebContentsObserver,
- observers_,
- DocumentLoadedInFrame(render_frame_id, render_view_host));
+ FOR_EACH_OBSERVER(
+ WebContentsObserver, observers_, DocumentLoadedInFrame(rfh));
}
void WebContentsImpl::OnDidFinishLoad(
@@ -2618,12 +2612,8 @@ void WebContentsImpl::OnDidFinishLoad(
RenderFrameHostImpl* rfh =
static_cast<RenderFrameHostImpl*>(render_frame_message_source_);
- int render_frame_id = rfh->GetRoutingID();
- RenderViewHost* render_view_host = rfh->render_view_host();
- bool is_main_frame = rfh->frame_tree_node()->IsMainFrame();
- FOR_EACH_OBSERVER(WebContentsObserver, observers_,
- DidFinishLoad(render_frame_id, validated_url,
- is_main_frame, render_view_host));
+ FOR_EACH_OBSERVER(
+ WebContentsObserver, observers_, DidFinishLoad(rfh, validated_url));
}
void WebContentsImpl::OnDidStartLoading(bool to_different_document) {

Powered by Google App Engine
This is Rietveld 408576698