chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc - Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix CrOS test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_contents.cc ('k') | chrome/browser/ui/search/instant_search_prerenderer_unittest.cc » ('j') | components/dom_distiller/content/dom_distiller_viewer_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

index a13cc50353da1a6c14aad0e736fc96d27ca6ae06..ddbe7cf6150b23f64ab84fdb04f2a99699b9a412 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc

@@ -39,11 +39,8 @@ class ContentsObserver : public WebContentsObserver {

bool got_favicons() const { return got_favicons_; }

// WebContentsObserver overrides.

- virtual void DidFinishLoad(

- int64 frame_id,

- const GURL& validated_url,

- bool is_main_frame,

- content::RenderViewHost* render_view_host) OVERRIDE {

+ virtual void DidFinishLoad(content::RenderFrameHost* render_frame_host,

+ const GURL& validated_url) OVERRIDE {

loaded_ = true;

}