Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1732)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix one more compile error Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index 32e33478710f373079cc6f4534f7fbaeccd0caae..d09ad08186885c95c4860108312108e159d56d4f 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -227,7 +227,6 @@ WebViewGuest::WebViewGuest(content::BrowserContext* browser_context,
pending_context_menu_request_id_(0),
next_permission_request_id_(0),
is_overriding_user_agent_(false),
- main_frame_id_(0),
chromevox_injected_(false),
current_zoom_factor_(1.0),
find_helper_(this),
@@ -1043,10 +1042,8 @@ void WebViewGuest::DidCommitProvisionalLoadForFrame(
DCHECK(zoom_controller);
current_zoom_factor_ = zoom_controller->GetZoomLevel();
- if (!render_frame_host->GetParent()) {
+ if (!render_frame_host->GetParent())
chromevox_injected_ = false;
- main_frame_id_ = render_frame_host->GetRoutingID();
- }
}
void WebViewGuest::DidFailProvisionalLoad(
@@ -1074,10 +1071,9 @@ void WebViewGuest::DidStartProvisionalLoadForFrame(
}
void WebViewGuest::DocumentLoadedInFrame(
- int64 frame_id,
- content::RenderViewHost* render_view_host) {
- if (frame_id == main_frame_id_)
- InjectChromeVoxIfNeeded(render_view_host);
+ content::RenderFrameHost* render_frame_host) {
+ if (!render_frame_host->GetParent())
+ InjectChromeVoxIfNeeded(render_frame_host->GetRenderViewHost());
}
bool WebViewGuest::OnMessageReceived(const IPC::Message& message,
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.h ('k') | chrome/browser/password_manager/password_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698