Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/dom_distiller/tab_utils_browsertest.cc

Issue 373623002: Convert remaining WebContentsObservers loading callbacks to use RFH. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix one more compile error Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_distiller/tab_utils_browsertest.cc
diff --git a/chrome/browser/dom_distiller/tab_utils_browsertest.cc b/chrome/browser/dom_distiller/tab_utils_browsertest.cc
index 37bd4f293b607ccbbc0b0c22f97713961941f7a6..c3c0c910f31f95dd0ef3bdb24c20219964a9abb7 100644
--- a/chrome/browser/dom_distiller/tab_utils_browsertest.cc
+++ b/chrome/browser/dom_distiller/tab_utils_browsertest.cc
@@ -45,12 +45,10 @@ class WebContentsMainFrameHelper : public content::WebContentsObserver {
content::WebContentsObserver::Observe(web_contents);
}
- virtual void DidFinishLoad(
- int64 frame_id,
- const GURL& validated_url,
- bool is_main_frame,
- content::RenderViewHost* render_view_host) OVERRIDE {
- if (is_main_frame && validated_url.scheme() == chrome::kDomDistillerScheme)
+ virtual void DidFinishLoad(content::RenderFrameHost* render_frame_host,
+ const GURL& validated_url) OVERRIDE {
+ if (!render_frame_host->GetParent() &&
+ validated_url.scheme() == chrome::kDomDistillerScheme)
callback_.Run();
}

Powered by Google App Engine
This is Rietveld 408576698